[MPlayer-dev-eng] Re: [PATCH] OSD cleanup

[Alban Bedel]

On Thu, 17 Nov 2005 23:46:45 +0200
Ivan Kalvachev <ikalvachev at gmail.com> wrote:

> 2005/11/15, Alban Bedel <albeu at free.fr>:
> > On Mon, 14 Nov 2005 12:45:30 +0100
> > Paul TT <paultt at hackerjournal.it> wrote:
> >
> > > On Thu, 10 Nov 2005 16:45:22 -0600
> > > Joey Parrish <joey at nicewarrior.org> wrote:
> > >
> > > > On Thu, Nov 10, 2005 at 12:26:29AM +0100, Paul TT wrote:
> > > > > On Tue, 8 Nov 2005 18:51:39 +0100
> > > > > Alban Bedel <albeu at free.fr> wrote:
> > > > > > The subtitles switching stuff is a total mess, i intend to move
> > > > > > that code out of main() later so i currently left it more or less
> > > > > > as is.
> > > > >
> > > > > ...
> > > > > i'll try yr patch as soon as i'll be able to do :-)
> > > >
> > > > I just committed code that broke your patch, so here's another
> > > > revision
> > > > of the OSD cleanup which takes into account the border control
> > > > message.
> > > > Applies cleanly to latest CVS.
> >
> > Thks guys for keeping that patch up to date.
> >
> > > tried the patch:
> > >
> > > three points, up to now, in term_osd:
> > > . behaviour of 'o' key (osd): in term mode i think it should only
> > > notify enabled/disabled and not the other two conditions
> >
> > That would make more sense.
> 
> The code seems to be committed and I find this new behaviour disgusting.
> When I cycle trough modes using 'o' i see one "osd disable" and 3 "osd
> enable" that also hide the timer mode, so it now basically less
> verbose that before "osd en/disable" patch.

Hmm i really don't see what your are talking about, here nothing changed in
the behaviour of the osd command (tested with vo x11 and xv).

> Please, fix that!
> Please, revert to old behaviour.

Please, send proper bug reports.

	Albeu