[MPlayer-dev-eng] [PATCH] fix to Makefile uninstall

Diego Biurrun diego at biurrun.de
Tue Nov 15 16:25:31 CET 2005


On Tue, Nov 15, 2005 at 03:49:31PM +0100, Paul TT wrote:
> 
> cvs commit: [14:45:37] waiting for anonymous's lock in
> /cvsroot/mplayer/main

Send Attila a mail so he can remove the lock.

> -	  if test "i$$l" != "en"; then \
> -	    -rm -f $(MANDIR)/$$l/man1/mplayer.1 $(MANDIR)/$$l/man1/mencoder.1 \
> -	    -rm -f $(MANDIR)/$$l/man1/gmplayer.1 \
> -	  fi \
> +	  if test "$$l" != "en"; then \
> +	    rm -f $(MANDIR)/$$l/man1/mplayer.1 \
> +	    $(MANDIR)/$$l/man1/mencoder.1   \
> +	    $(MANDIR)/$$l/man1/gmplayer.1 ; \

OK, this is really just a nit, but I would indent this properly as well,
so either

    -rm -f $(MANDIR)/$$l/man1/mplayer.1 $(MANDIR)/$$l/man1/mencoder.1 \
           $(MANDIR)/$$l/man1/gmplayer.1 \

or if you prefer

    -rm -f $(MANDIR)/$$l/man1/mplayer.1  \
           $(MANDIR)/$$l/man1/mencoder.1 \
           $(MANDIR)/$$l/man1/gmplayer.1 \

That should be more readable.

Diego




More information about the MPlayer-dev-eng mailing list