[MPlayer-dev-eng] [PATCH] charset checking for TOOLS/checktree.sh

[Ivo]

On Thursday 10 November 2005 22:22, Reimar Döffinger wrote:
> Hi,
> since I was told that source files are supposed to be ascii-only, I
> decided to find out what that would actually mean.
> Apply attached patch and then run
> TOOLS/checktree.sh -charset
> Have much fun :-P

:)

> P.S.: should I apply this?

I don't really mind non-ascii in comments and some of the language strings, 
but if we adopt the strict rule that all source files are to be ascii-only, 
I think it's good to have this check in here. But, your check dumps all the 
offending lines, and all other checks just print the filenames of the files 
that don't pass the check. I once thought of adding an option, so each 
check could either print a list of filenames and just that, or it could 
also dump the offending lines per file, but I never got around to making 
it. If you want, you can add that :) Otherwise, I think the charset check 
should also just print a list of files that have non-ascii characters in 
them. Or maybe not, since it's not on by default? What do you think?

--Ivo