[MPlayer-dev-eng] [PATCH] misc small fixes (mostly gcc warnings)

[Dominik 'Rathann' Mierzejewski]

On Thursday, 10 November 2005 at 02:27, Diego Biurrun wrote:
> On Thu, Nov 10, 2005 at 01:34:33AM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > Yes, it's this time of the year again.
> 
> :)
> 
> > 12. muxer_mpeg.c:2315: warning: implicit declaration of function 'mp_get_mp3_header'
> >     muxer_mpeg.c:2339: warning: implicit declaration of function 'a52_syncinfo'
> > 
> > #include "mp3_hdr.h"
> > #include "../liba52/a52.h"
> 
> Please don't add (more) .. #includes.  Since -I.. is in the CFLAGS this
> is unnecessary.

Right, I somehow missed that. That's why I'm posting this here first. ;)

> > 21. sysdep/pci_linux.c:93: warning: implicit declaration of function 'iopl'
> > 
> > Gabu said including <sys/perm.h> broke compilation on his libc5 system, but...
> 
> Let's try not to break libc5 systems unnecessarily...

Maybe so, but using undeclared function calls is not good either.
Perhaps there's some #ifdef we can use to detect a libc5 system?

R.

-- 
MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/
"I am Grey. I stand between the candle and the star. We are Grey.
 We stand between the darkness ... and the light."
        -- Delenn in Grey Council in Babylon 5:"Babylon Squared"