[MPlayer-dev-eng] Re: [PATCH] OSD localization third try

[Tobias Diedrich]

Diego Biurrun wrote:
> On Sun, Nov 06, 2005 at 03:40:01PM +0100, Tobias Diedrich wrote:
> > Paul TT wrote:
> > 
> > > > With --encoding=utf-8 I get garbage for non-ascii characters on the
> > > > OSD (looks like MPlayer's treating the string as iso-8859-1 anyway).
> > > > Probably there needs to be some charset dependend iconv conversion
> > > > in the OSD code.
> > > 
> > > i'm looking at it...
> > 
> > Well, semidirty fix attached.
> > 
> > +_def_mp_help_is_utf8="#define MP_HELP_IS_UTF8 0"
> > +     _def_mp_help_is_utf8="#define MP_HELP_IS_UTF8 1"
> > +$_def_mp_help_is_utf8
> 
> I'd prefer if you could call this MP_HELP_MULTIBYTE or similar.
> Otherwise the configure part looks OK.

Well, the code enabled by this only deals with UTF8, other multibyte
encodings are entirely different beasts.  I'll rewrite it to use
iconv when I find the time (Maybe Wednesday).

-- 
Tobias						PGP: http://9ac7e0bc.uguu.de