[MPlayer-dev-eng] PATCH to support theora-exp in mplayer

Rich Felker dalias at aerifal.cx
Wed May 25 17:39:52 CEST 2005


On Wed, May 25, 2005 at 01:56:45AM -0400, Timothy B. Terriberry wrote:
> Rich Felker wrote:
> > HELL NO! I would never suggest anything idiotic like that!!!
> > 
> > I said to keep the first frame in the demuxer private area so that you
> > could demux it next time the demuxer is called. NOT IN THE EXTRADATA!!
> 
> My mistake (it _is_ 2 in the morning, and I've been working since 7:30
> yesterday morning). That makes me think you're slightly less off your
> rocker. Actually, a better solution would probably be to not pass the
> header packets on to the ds layer at all, but read them directly from
> the Ogg stream in demux_ogg_open(), and pass only data packets along in
> demux_ogg_fill_buffer() (similar to other demuxer's behavior, since they
> will have no header packets). Still seems like a lot more needless
> complexity than a simple 7-line function. In either case, I don't have
> more time to look at this tonight.

Yes, I like your proposed solution better. The header packets should
never enter the ds layer.

Rich




More information about the MPlayer-dev-eng mailing list