[MPlayer-dev-eng] [PATCH] GGI driver update

[Diego Biurrun]

On Wed, May 11, 2005 at 07:23:41AM +0200, Christoph Egger wrote:
> > 
> > The test for $_ggi should go along with the test for the extension,
> > something like this:
> > 
> > echocheck "GGI extension: libggiwmh"
> > if test "$_ggi" = yes && test "$_ggiwmh" = auto ; then

Lol, but in my template, the test should only be run in the auto case of
course...

[...]
> > echores "$_ggiwmh"
> 
> Thank you for this guidance. I'm only familiar with
> autoconf generated configure scripts...

You're welcome.

> I think you will like this patch better.

Yes.

> > > > > +#ifdef HAVE_GGIWMH
> > > > > +    if (ggiWmhInit() < 0) {
> > > > > +	mp_msg(MSGT_VO, MSGL_FATAL, "[ggi] unable to initialize
> > libggiwmh\n");
> > > > > +	return(-1);
> > > > 
> > > > You're messing up the indentation here by mixing spaces and tabs,
> > please
> > > > don't.
> > > 
> > > fixed.
> > 
> > Not in the version you sent.  Maybe you mixed up patches?
> 
> umm... yes, sorry.

I was referring to the tabs in front of the mp_msg and return calls.
They're still there, but never mind, looking at the file again I see it
is a mix of tabs and spaces all over, especially in that function, so at
least it is consistently mixed up now.

I'll trust you on the vo_ggi part of the patch, after all you are the
maintainer of that file ;-)

Patch applied.

Diego

P.S.: Please don't CC me, I follow dev-eng.