[MPlayer-dev-eng] [PATCH] vo_directx leaks when -loop 0 is used

[Timothy Lee]

Dear all,

OK, revised patch attached.  Window class names now #define'd since 
they're used so often.  uninit() now frees up all GDI resources.


Regards,
Timothy


Rich Felker wrote:

>On Tue, May 10, 2005 at 09:17:40AM +0800, Timothy Lee wrote:
>  
>
>>Dear Sascha,
>>
>>    
>>
>>>>   * GDI leaks caused by the creation of icon and brushes every time
>>>>     preinit() is called
>>>>   
>>>>
>>>>        
>>>>
>>>I think it would be better if the brush and icon were destroyed during
>>>uninit()
>>>Could you update your patch to do this?
>>> 
>>>
>>>      
>>>
>>Then UnregisterClass() would have to be called in uninit() as well,
>>since the icon and brushes are tied to the window class. With a '-loop
>>0' option, this leads to alternating calls to RegisterClass() and
>>UnregisterClass(), which is not very efficient...
>>    
>>
>
>This is only the case if -fixed-vo is omitted. Otherwise init/uninit
>are only called once, which is the proper way to use -loop anyway...
>
>Rich
>  
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vo_directx-loop0.patch
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050511/65b517ee/attachment.txt>