[MPlayer-dev-eng] [PATCH] mplayer.c

[Joey Parrish]

On Sun, Mar 27, 2005 at 09:10:39PM +0200, Björn Sandell wrote:
> Avoid some missing sentinel warnings.

> -          if (execlp("gdb", "gdb", prog_path, spid, NULL) == -1)
> +          if (execlp("gdb", "gdb", prog_path, spid, (void *)NULL) == -1)

> -          execl("/bin/sh","sh","-c",cmd->args[0].v.s,NULL);
> +          execl("/bin/sh","sh","-c",cmd->args[0].v.s,(void *)NULL);

This is silly.  There should be no need to cast compatible constants.

1) NULL should always be assumed to be a pointer (common sense)
2) even treating NULL as int, C doesn't care about such stupid
    casting, only C++ would complain

What good is this patch?  What is sentinel?

--Joey

-- 
"You think without your internal dialog, and I have red socks." --Prem