[MPlayer-dev-eng] [PATCH] pic working with x86

[D Richard Felker III]

On Fri, Mar 25, 2005 at 11:47:42AM +0100, Jindrich Makovicka wrote:
> Chris White wrote:
> >Ok, here's a rather long patch I made against -pre6 to get pic working 
> >with MPlayer under gentoo.  Please note that 3dnow, 3dnowex, mmx, and 
> >mmx2 extensions were disabled to get pic working.
> 
> --- MPlayer-1.0pre6a_old/postproc/swscale_template.c	2004-10-22 
> 09:21:57.000000000 +0900
> +++ MPlayer-1.0pre6a/postproc/swscale_template.c	2005-03-21 
> 16:06:21.531201296 +0900
> @@ -2334,7 +2334,11 @@
> 
> 
>  		:: "r" (src), "m" (dst), "m" (dstWidth), "m" (xInc>>16), "m" 
> (xInc&0xFFFF)
> +#ifdef __PIC__
> +		: "%"REG_a, "%ecx", "%"REG_D, "%esi"
> +#else
>  		: "%"REG_a, "%"REG_b, "%ecx", "%"REG_D, "%esi"
> +#endif
>  		);
>  #ifdef HAVE_MMX2
>  	} //if MMX2 can't be used
> 
> so why do you need this conditional, when MMX & al. are disabled? things 
> won't start magically work just by removing ebx from the clobber list.

Like I said, this patch looks totally broken.
I doubt it was even tested. Best to ignore broken junk from such
"contributors" since it's likely to be full of bugs even after
debugging.

Rich