[MPlayer-dev-eng] [PATCH] pic working with x86

[D Richard Felker III]

On Fri, Mar 25, 2005 at 02:25:12PM +0900, Chris White wrote:
> Ok, here's a rather long patch I made against -pre6 to get pic working 
> with MPlayer under gentoo.  Please note that 3dnow, 3dnowex, mmx, and 
> mmx2 extensions were disabled to get pic working.  That means the user 
> has to manually do that, or logic can be built into configure to 
> accomidate this. Haven't got that far yet.  Also, since our libtool 
> works with __PIC__ instead of PIC with regards to defines.  I'm not sure 
> if that's specific or not, but I did a sed-ing like so:
> 
>    sed -i -e 's/#if\(\(.*def *\)\|\(.*defined *\)\)PIC/#if\1__PIC__/' \
>        libavcodec/i386/dsputil_mmx{.c,_rnd.h} \
>        libavcodec/msmpeg4.c \
>        libavcodec/libpostproc/mangle.h \
>        libavcodec/common.h \
> 
> to create the "patch".  I'm not sure if you'd rather have -DPIC as an 
> alternative.  So then.. on to the fun.
> I've pasted the patch inline so I can comment on what's being done.  
> Comments are indicated by ###'s for readability.  The uncommented patch 
> exists here:
> 
> http://dev.gentoo.org/~chriswhite/mplayer-1.0_pre6-pic.patch

Rejected, the conditional compilation code looks all wrong, but most
importantly PIC has no use in mplayer. All it does is make it
incredibly slow. If you have some reason for trying to do this, please
explain, but otherwise I don't think we'll be interested.

Rich