[MPlayer-dev-eng] [PATCH] Makefile change for shared libpostproc installation

Diego Biurrun diego at biurrun.de
Wed Mar 23 11:07:25 CET 2005


On Wed, Mar 23, 2005 at 09:15:13AM +0100, Alexander Strasser wrote:
> Michael Niedermayer wrote:
> > 
> > On Wednesday 23 March 2005 02:26, Diego Biurrun wrote:
> > > On Mon, Mar 21, 2005 at 09:17:03PM +0100, Michael Niedermayer wrote:
> > > > On Saturday 19 March 2005 18:40, Diego Biurrun wrote:
> > > > > On Sat, Mar 19, 2005 at 06:34:44PM +0100, Diego Biurrun wrote:
> > > > > > This is a Makefile change for shared libpostproc installation.
> > > > >
> > > > > .. and oh wonder, i forgot to attach the patch, *sigh*.
> > > >
> > > > patch looks ok, feel free to commit (assuming it works and doesnt work
> > > > without the patch)
> > >
> > > No, I'm afraid the patch is not enough, since FFmpeg uses $(libdir) in
> > > its Makefiles, while MPlayer uses $(LIBDIR).
> > >
> > > What do you guys consider the cleanest solution to this?  Change
> > > everywhere in MPlayer/FFmpeg or work around it in configure by putting
> > > something like libdir=\$(LIBDIR) into config.mak?
> > 
> > hmm, i dunno if renaming one of them would be a good or bad idea, and as a 
> > simple 1 line workaround solves this iam in favor of it instead of a pretty 
> > large change
> 
> I am also for the ``workaround''. But please add also a comment about it.

Done.

Diego




More information about the MPlayer-dev-eng mailing list