[MPlayer-dev-eng] [PATCH] a few warnings (mpeg_hdr.c)

Nico Sabbi nsabbi at tiscali.it
Wed Mar 2 00:26:56 CET 2005


Dominik 'Rathann' Mierzejewski wrote:

>Hi.
>
>Attached patch fixes:
>mpeg_hdr.c:212: warning: no return statement in function returning non-void
>mpeg_hdr.c:262: warning: suggest parentheses around assignment used as truth value
>mpeg_hdr.c:264: warning: suggest parentheses around assignment used as truth value
>mpeg_hdr.c:270: warning: suggest parentheses around assignment used as truth value
>mpeg_hdr.c:275: warning: suggest parentheses around assignment used as truth value
>mpeg_hdr.c:212: warning: control reaches end of non-void function
>
>mp4_header_process_vop() return value isn't used anywhere anyway.
>If there are no objections, I'll apply it in a couple of days.
>
>Regards,
>R.
>  
>
[snip]

>   
>-  if(overscan=getbits(buf, n++, 1))
>+  if((overscan=getbits(buf, n++, 1)))
>  
>

is gcc so idiotic?

Ok to commit for me




More information about the MPlayer-dev-eng mailing list