[MPlayer-dev-eng] [PATCH] negating unsigned in asm code

Diego Biurrun diego at biurrun.de
Thu Jun 30 10:56:04 CEST 2005


On Tue, Jun 28, 2005 at 12:39:31PM +0200, Reimar Döffinger wrote:
> rgb2rgb_template.c causes a lot of crashes on AMD64, since the current
> code first negates unsigned variables and then extends them to 64 bits,
> the result being a very big positive value instead of a negative one.
> One possibility would be making all unsigned signed.
> The attached patch instead does the subtraction/negating in assembler,
> which fixes this as well (a bit at the cost of readability, but not much
> IMHO).

Why not go with the signed solution?  Seems cleaner to me...

Diego




More information about the MPlayer-dev-eng mailing list