[MPlayer-dev-eng] [PATCH] Re: mencoder -oac copy does not work all the times.

[Rich Felker]

On Wed, Jun 29, 2005 at 08:40:20PM -0400, Giacomo Comes wrote:
> On Thu, Jun 30, 2005 at 02:21:05AM +0200, Tobias Diedrich wrote:
> > Giacomo Comes wrote on Mon, 17 Jan 2005:
> > > I have found that -oac copy produces incorrect results
> > > in some particular cases.
> > > 
> > > Here is a simple way to test the bug;
> > > take a dvd with LPCM audio and do:
> > > 
> > > mencoder dvd://1 -ovc frameno -oac copy -aid 160 -frames 500 -o file.avi
> > > 
> > > Now play file.avi: mplayer file.avi
> > > 
> > > You will get only loud noise.
> > 
> > I propose fixing this by refusing audio streamcopy if
> > sh_audio->format does not fit into mux_a->wf->wFormatTag, patch
> > attached.
> 
> I would like a different patch. If sh_audio->format does not fit into mux_a->wf->wFormatTag
> issue a WARNING , but still do audio streamcopy.

Agree. The patch can either make it a warning or an error, but it
needs to add -ftwocc options (like -ffourcc) to force a new tag.. Then
we can make new twocc's for storing random crappy audio formats in
avi.. :)

Rich