[MPlayer-dev-eng] [PATCH] lirc repeat patch
Lev A. Melnikovsky
leva at despammed.com
Tue Jun 28 00:09:53 CEST 2005
Hi, there,
On Mon, 27 Jun 2005 at 10:16am, Reimar Dцffinger wrote:
> I very much prefer this patch since it is smaller and IMHO easier to
> understand).
Well, I think the former version was more speed (and size) effective, but
input interface of mplayer is not the proper place for such optimizations.
Readability is more important here (and I've finally got rid of that ugly
while(1) loop).
> I didn't add the default: - you are right that it should be there but it
> should result in an error not silently ignored.
I agree, that's why I've inserted the "default:" branch right _before_ the
mp_msg() call. Not noisy enough?
> harder to believe that there are people who won't believe me that
> programming is some kind of art, too ;-) ).
Do you mean to suggest the list renaming to mplayer-art-eng? If you need
my vote - you already have it! :-)
Regards
--
Leva
More information about the MPlayer-dev-eng
mailing list