[MPlayer-dev-eng] [PATCH] Coring filter

[Diego Biurrun]

On Mon, Jun 27, 2005 at 11:47:36AM +0200, Jan Paul Schmidt wrote:
> 
> Am 27.06.2005 um 10:43 schrieb Diego Biurrun:
> 
> >On Sun, Jun 26, 2005 at 11:28:12PM +0200, Jan Paul Schmidt wrote:
> >>
> >>this is my type of a coring filter for MPlayer/MEncoder. See
> >>attachments. vf_coring.c is the new filter file and vf_coring.diff the
> >>patches to integrate it into the source tree.
> >
> >In the man page you need to start sentences on a new line
> 
> What do you mean by that? It looks like other filter entries here?

Look at the code, not the groff output.

> >Apart from that you should describe the filter's purpose and 
> >shortcomings in more detail.
> 
> Good point.
> 
> >The discussion with Rich shows that this is necessary.
> 
> Does it? Rich understood the filter, I think.

The discussion shows that the filter has some features and limitations that
are not obvious from the two line description.  Thus you should explain them
so that not only filter wizards can deduce them.

Diego