[MPlayer-dev-eng] [PATCH] lirc repeat patch

[Guillaume POIRIER]

Hi,

On 6/21/05, Lev A. Melnikovsky <leva at despammed.com> wrote:
> Dear Guillaume,
> 
>    On Mon, 20 Jun 2005 at 10:20pm, Guillaume POIRIER wrote:
> 
> > What was that patch again? Could you send a reminder to it? I'll try to
> > have a look at it, but I can't promise anything.
> Thank you for your suggestion. I was not sure about resending the patch
> again to the list, so I'm just forwarding the messages to you.

In general, it's better (meaning that it's better practice, and won't
get on people's nerves) to just send a reminder as a reply to the mail
you sent to the list to ask if it has been considered.

[..]

> Modern lirc (0.7.0) sends multiple empty events when "repeat" is specified
> in the config file. For instance, the line "repeat 32" (my remote sends 32
> events for each Volume_Up press) will lead to 31 empty events and 1
> sensible one. The patch makes mplayer swallow all available events at
> once, not one at a time - this greatly improves responsiveness.

That would be great if you could test what happens when you use this
patch with an older version of lirc, in order to make sure that it
doesn't introduce a regression.

You also have a while(1) loop, which is something I personally don't
like (maybe it's make MPlayer deadlock). Could you maybe replace it by
a bounded loop?

It would be quite nice if you could add some more comments on your
code, while you're at it.

Regards,
Guillaume
-- 
A woman isn't complete without a man.
But where do you find a man - a real man - these
days?
  -- Lauren Bacall
My answer: Only at #mplayerdev on the freenode IRC network.