[MPlayer-dev-eng] [PATCH] fix non-showing subtitles

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jun 18 20:49:18 CEST 2005


Hi,
this patch seems to fix those cases where subtitles don't appear.
Might break some other subtitles though (maybe just increasing the limit
would be a better idea??).
But I guess we might get away with it since there's that complicated check
at the end...
Please comment or at least test. Unless you have a better idea, I'd
suggest applying in the hope that it works - if not we will at least get
some samples to check out the border cases.
On the subject of samples:
http://www.mplayerhq.hu/MPlayer/incoming/starwarssub2.vob shows this
problem quite nicely, maybe somebody could add it to the samples?

Greetings,
Reimar Döffinger
-------------- next part --------------
--- spudec.c	2005-01-22 01:41:35.000000000 +0100
+++ spudec.c	2005-06-16 20:07:44.000000000 +0200
@@ -503,10 +503,12 @@
       mp_msg(MSGT_SPUDEC,MSGL_WARN,"SPUasm: packet too short\n");
       return;
   }
+#if 0
   if ((spu->packet_pts + 10000) < pts100) {
     // [cb] too long since last fragment: force new packet
     spu->packet_offset = 0;
   }
+#endif
   spu->packet_pts = pts100;
   if (spu->packet_offset == 0) {
     unsigned int len2 = get_be16(packet);


More information about the MPlayer-dev-eng mailing list