[MPlayer-dev-eng] [PATCH] Show OSD status when cicling with 'o'

[Paul TT]

On Thu, 16 Jun 2005 11:27:59 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hi,
> On Thu, Jun 16, 2005 at 11:07:30AM +0200, Paul TT wrote:
> > in this situation i'm in slave mode, right. so maybe is more correct to test slave_mode?
> > or am i wrong????
> Not really beautiful either IMHO. Some people use slave mode even
> without using a full external gui, but only to do some kind of
> remote-controlling. I don't really like it when MPlayer behaves
> differently then.
> Also in theory it would be possible to make a GUI without using -slave,
> by sending key commands. And last but not least MPlayer sends commands
> internally as well. Changing the OSD state is (currently?) not among
> those, but still.

you're absolutely right here

> Even if (v < 0) is too general IMHO, I'd say make it if (v == -1)
> instead, like that anyone can get the old behaviour by assigning
> osd -2
> to the o key. Or do if (v == -2), then everyone who wants this feature
> has to explicitly enable it.
> Btw. is it neccessary to set osd_changed every time? Would be better to
> avoid it for performance reasons, at least vo_gl can save itself some
> work then...

i don't understand the point about this. if i'm switching osd's then on the screen would be flickering time and percentage of playing, then performance would be affected too.
having v defined doesn't prevent me from switching with 'o', then, why restrict it to -1 case?????
maybe it's better off restrict it to -2, if not make this default

i understand your point when you say not to set osd_changed everytime when osdlevel is set to 0 at startup. in that case i think would be more correct to not show osd at all, or not????