[MPlayer-dev-eng] [PATCH] Show OSD status when cicling with 'o'

[kiriuja]

On Tue 14 Jun 2005 04:05, Paul TT wrote:
> On Thu, 9 Jun 2005 18:28:04 -0400
> kiriuja <mplayer-patches at en-directo.net> wrote:
> 
> > On Thu 09 Jun 2005 07:28, Diego Biurrun wrote:
> > > On Wed, Jun 08, 2005 at 05:15:00PM -0400, kiriuja wrote:
> > > > On Wed 08 Jun 2005 06:37, Paul TT wrote:
> > > > > i added a little message to show up when OSD display status level changes to disabled or enabled (0 or 1 levels)
> > > > 
> > > > The message should only be shown when the level argument is not given explicitly:
> > > > 
> > > > if (v < 0 && osd_level <= 1)
> > > >   osd_show_status = 9; // show state when disabled
> > > 
> > > Why?
> > 
> > Well, first of course if you give an explicit argument you are saying
> > ......
> > So if the patch says "if (slave_mode == 0)" instead of "if (v < 0)"
> > that will be fine with me as well. If a frontend wants to display the
> > message, it can always say osd_show_text "OSD: disabled" a second or
> > two before "osd 0".
> 
> it shows up only when switching pressing 'o' r-dev-eng

Pressing 'o' sends an "osd" command to the input layer. When a frontend
sends and "osd 0" or "osd 1", the same code is executed. So the (v < 0)
check is needed if you want the message to only show when the 'o' key
is pressed. This is my only objection to your patch.

--
kiriuja