[MPlayer-dev-eng] [PATCH] fix for segmentation fault in ao_nas

[Guillaume POIRIER]

Hi,

On 5/27/05, Erik Auerswald <auerswal at unix-ag.uni-kl.de> wrote:
> Hi,
> 
> audio output using ao_nas sometimes crashes mplayer with a segmentation
> fault. This is caused by NAS server messages requesting large amounts of
> data. One error in libao2/ao_nas.c is subtracting an AuUint32 from an int
> value. The other is not checking if enough data is in the buffer to
> fulfill the request.
> 
> The latter problem is solved by limiting the sent data to the available
> amount of data. The former can be solved by either using 64bit integer
> types or checking the AuUint32 for values that overflow an int in the
> current implementation.
> 
> I've attached 2 alternative patches, one for each of the overflow fixes,
> because I'm not sure which way is "better".
> 
> Erik
> 
> P.S. I've already sent alternative 1 to this list, but I didn't use the
> [PATCH] subject line, so it probably was overlooked.

Has anyone had a look at it?

Guillaume
-- 
I should have invented the tape recorder,
that way people would have more quotes of
me to put at the bottom of their e-mails
-- Benjamin Franklin