[MPlayer-dev-eng] [PATCH] Clean up ao_macosx by removing AudioConverter

Chris Roccati roccati at pobox.com
Fri Jun 10 21:45:46 CEST 2005


On 7 Jun 2005, at 17:05 , Alexander Strange wrote:

> This patch removes the use of AudioConverters from the macosx audio  
> output; AUHAL can do all conversion internally and more efficiently  
> than trying to do it before the AudioOutputUnit ever sees any data.

It works fine (although I see no real difference in performance).
I didn't actually understand Apple's documentation about the AudioUnits.

I suggest you to check for the various "cosmetic" edits and provide a  
"corrected" version for committal.

> There are two potential issues left in ao_macosx that I can see:
> * Ever since ao_macosx was changed to use AUHAL, I've been having a  
> problem where the first frame of a movie shows up extremely late  
> and mplayer skips a lot more frames than normal for a while before  
> settling down. I think this patch has changed it a little, but I'll  
> have to look into it more.

This appears to happen because of a massive audio buffer underrun  
when the movie starts, which I can't seem to track





More information about the MPlayer-dev-eng mailing list