[MPlayer-dev-eng] [PATCH] Non-blocking mp_msg

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Fri Jun 10 10:58:04 CEST 2005


Hi,
On Thu, Jun 09, 2005 at 02:04:02PM +0300, Paul Pedaal wrote:
> >   I am not sure if we really need this at all.
> > But at least it may have portability issues i guess...
> 
> The most annoying is using mplayer with screen. When screen displays one if its own messages it blocks the stdout for the program in the current window. You will get  a freezed mplayer every time screen thinks there is something to tell you :(
> 
> poll() should exist on any OS that offers SysV system calls. select() can be used on Berkley-compatible systems.
> This is something that can be checked for in the configure script. My little patch (and my skills) don't have that unfortunately :( I just wrote it to make mplayer behave better in screen.

First, even if they exist I'm not sure if they behave exactly the same.
Second, this patch IMHO defeats the purpose of using fflush at all, that
is making sure the messages appear at the right time in the right order.
Instead of this complicated patch, just doing
#define fflush
somewhere in mp_msg.c should have the same effect...

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list