[MPlayer-dev-eng] [PATCH] Show OSD status when cicling with 'o'

[kiriuja]

On Thu 09 Jun 2005 07:28, Diego Biurrun wrote:
> On Wed, Jun 08, 2005 at 05:15:00PM -0400, kiriuja wrote:
> > On Wed 08 Jun 2005 06:37, Paul TT wrote:
> > > i added a little message to show up when OSD display status level changes to disabled or enabled (0 or 1 levels)
> > 
> > The message should only be shown when the level argument is not given explicitly:
> > 
> > if (v < 0 && osd_level <= 1)
> >   osd_show_status = 9; // show state when disabled
> 
> Why?

Well, first of course if you give an explicit argument you are saying
"switch to this particular osd level" rather than "switch to the next
level whatever that happens to be", so you are supposed to know what
level you are switching to.

Second, if you get an explicit argument, that means you are most likely
running inside a -slave frontend. A frontend may choose a different way
of showing the current osd level, and in that case this message is just
spam that there is no way to turn off if this patch is committed as is.

So if the patch says "if (slave_mode == 0)" instead of "if (v < 0)"
that will be fine with me as well. If a frontend wants to display the
message, it can always say osd_show_text "OSD: disabled" a second or
two before "osd 0".

If a frontend says "osd 0", that means "no osd of any kind, full stop".
"osd 1" *should* mean "no osd other than subtitles", but unfortunately
right now it also displays "Subtitles: off" and "Subtitles: whatever"
crap when doing sub_select. I will try to work around it with something
like

osd 0
sub_select ...
osd_show_text ""
osd 1

but even if that helps, I will probably submit a patch disabling that
spam in slave mode. If a frontend wants it, it can always say
osd_show_text "Subtitles: whatever"

--
kiriuja