[PATCH] Re: [MPlayer-dev-eng] osdep/fseeko.c problem []

[Arne Driescher]

Hi Corey,

I applied your patch and it works as describes in your e-mail.
Thank you very much for your quick help.


Best regards,
Arne

On Thursday 09 June 2005 06:15, Corey Hickey wrote:
........
>
> Thank you for that information.
>
> Vanilla gcc 3.3.5 does not support k8/opteron/athlon64/athlon-fx
> optimization. I verified this by reading the manpage from the source
> tarball. The stanza you quoted from your gcc manpage looks just like one
> from my gcc 3.4.4 manpage.
>
> In your configure.log I see:
> cc     /tmp/mplayer-conf-16730-10154.c -o
> /tmp/mplayer-conf-11986-10154.o -march=athlon-xp -mcpu=athlon-xp
> cc1: error: CPU you selected does not support x86-64 instruction set
> cc1: error: CPU you selected does not support x86-64 instruction set
>
> That's just like the error I see when I try to use -march=athlon-xp with
> gcc 3.4. Gcc 3.3 likes -march=athlon-xp but doesn't support
> -march=athlon64 (etc.). By example:
>
> bugfood at bugfood:/tmp$ gcc-3.3 hello.c -march=athlon-xp
> bugfood at bugfood:/tmp$ gcc-3.3 hello.c -march=athlon64
> cc1: error: bad value (athlon64) for -march= switch
> cc1: error: bad value (athlon64) for -mcpu= switch
> bugfood at bugfood:/tmp$ gcc-3.4 hello.c -march=athlon-xp
> hello.c:1: error: CPU you selected does not support x86-64 instruction set
> hello.c:1: error: CPU you selected does not support x86-64 instruction set
> bugfood at bugfood:/tmp$ gcc-3.4 hello.c -march=athlon64
>
>
> So, my tentative conclusion is that your gcc 3.3.5 has some broken
> backported patches from gcc 3.4 and configure has trouble because it
> expects your gcc to behave like the version it says it is.
>
> I wrote a patch that should fix that.
>
> Rather than try to work around your broken compiler, configure now
> optimistically sets proc=k8; if that fails with the gcc version being
> used, configure will fall back on proc=athlon-xp. That's actually how I
> did it for the corresponding 32-bit section, and it should work just fine.
>
> Configure now uses k8 instead of athlon64 (for both 32-bit and 64-bit).
> With non-broken gcc builds this really shouldn't make any difference,
> and it lets the broken suse version work.
>
>
> I've tested this patch on my athlon64 running 64-bit with gcc 3.3 and
> gcc 3.4. 32-bit operation is untested, though the change is trivial and
> I don't see why it won't work. Guillaume, can you verify that?
>
> -Corey