[MPlayer-dev-eng] [PATCH] Clean up ao_macosx by removingAudioConverter

[alexander.strange at ithinksw.com]

>
> On 7-Jun-05, at 11:05 AM, Alexander Strange wrote:
>
>>
>> (Also, a while ago I sent a patch that allowed float or 32-bit
>> output with more audio decoders, but it was apparently ignored. Now
>> that ao_macosx, at least, doesn't have all those buffer overflow/
>> clicking problems, and if anyone still has the patch, could it be
>> reviewed again?)
>>
>
> I cant find this patch im my archives. If you still have it please
> send it back, I will have a look at it.

I found it again by searching for my email address in gmane, but it turns
out that I remembered myself doing more work than I actually did, and the
patch is only to make ad_libmad output 32-bit integers rather than
truncating to 16-bit.

I like using mp3lib better these days, and the way it generates floats and
truncates them to 16-bit and then has them converted to floats in AUHAL
and truncated again for the sound hardware certainly isn't optimal, but
I'd have to fix decode_MMX.c and decode_i586.c as well and I've never
tried to learn x86 assembly. faad or tremor (or is it going to switch to
ffvorbis?) might be easy enough to do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MAD32.patch
Type: application/octet-stream
Size: 2381 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050607/9b1a162e/attachment.obj>