[MPlayer-dev-eng] [PATCH] Clean up ao_macosx by removing AudioConverter

Alexander Strange astrange at ithinksw.com
Tue Jun 7 17:05:54 CEST 2005


This patch removes the use of AudioConverters from the macosx audio  
output; AUHAL can do all conversion internally and more efficiently  
than trying to do it before the AudioOutputUnit ever sees any data.

There are two potential issues left in ao_macosx that I can see:
* Ever since ao_macosx was changed to use AUHAL, I've been having a  
problem where the first frame of a movie shows up extremely late and  
mplayer skips a lot more frames than normal for a while before  
settling down. I think this patch has changed it a little, but I'll  
have to look into it more.
* In order to properly support audio devices that can change frame  
rates, it might be necessary to set the output format of the  
AudioOutputUnit to the same thing as the input format. I'll look into  
this too.

(Also, a while ago I sent a patch that allowed float or 32-bit output  
with more audio decoders, but it was apparently ignored. Now that  
ao_macosx, at least, doesn't have all those buffer overflow/clicking  
problems, and if anyone still has the patch, could it be reviewed  
again?)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ao_macosx_no_audioconverter.patch
Type: application/octet-stream
Size: 3690 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050607/d1c12bc2/attachment.obj>


More information about the MPlayer-dev-eng mailing list