[MPlayer-dev-eng] [PATCH] Duplicated texts in help file

Diego Biurrun diego at biurrun.de
Mon Jun 6 18:11:49 CEST 2005


On Wed, Jun 01, 2005 at 05:29:42PM +0200, Torinthiel wrote:
> Some messages in help_mp-en.h are duplicated. Specifically:
> MSGTR_MENU_PlayList and MSGTR_PlayList: "Playlist"
> MSGTR_MENU_Preferences and MSGTR_Preferences: "Preferences"
> MSGTR_PREFERENCES_Audio and MSGTR_EQU_Audio: "Audio"
> MSGTR_PREFERENCES_Video and MSGTR_EQU_Video: "Video"
> MSGTR_PREFERENCES_FRAME_Misc and MSGTR_PREFERENCES_Misc: "Misc"
> 
> This means that two #defines in help-* are defined to exactly the same
> strings. The attached patch makes this more obvious, by defining one of
> them to the other.
> Rationale: 
> 1. Less duplication
> 2. Automatic generation of .po files that I'm working on will work
> 3. Translations can easily omit the duplicated string, help_diff.sh will
>    fix it correctly.
> 
> Disadvantages: 
> If one changes the master string it might go unnoticed. Maybe adding
> a short comment after the master string will help it.

I'd say commit it, but please also update the translations.

Diego




More information about the MPlayer-dev-eng mailing list