[MPlayer-dev-eng] [PATCH] version.sh behavior with Darwin
diego at biurrun.de
Sun Jun 5 16:21:20 CEST 2005
On Sat, Jun 04, 2005 at 07:10:09PM +0200, Chris Roccati wrote:
> I assumed it "almost worked" both on 10.3 and 10.4. In fact does not
> work on either, just in different ways...
> It turns out that 10.3.x ls says "-rw-r--r-- 1 chris staff 3413 2 Jun
> 21:29:35 2005 CVS/Entries" whereas 10.4.x ls says "-rw-r--r-- 1 chris
> staff 3413 Jun 2 21:29:35 2005 CVS/Entries".
Yes, ls on 10.3 is buggy when it comes to the effects locale is supposed
to have on date strings.
> Without the patch, no error is generated, but the output string is
> under 10.4, if the day of the month is less than 10 the version
> string is yymmd-hh:mm
> under 10.3, the version string is always yy00Mon-hh:mm
10.3 is buggy, as outlined above.
> This patch uses a perl version of the incantation if the os is
> Darwin. There's ALWAYS perl with darwin.
I'm torn about this. Yes, it's only one line and it does work, even on
10.3, but it does add another dependency and our policy has always been
not to work around environment bugs unless absolutely necessary.
Any more opinions?
More information about the MPlayer-dev-eng