[MPlayer-dev-eng] [PATCH] Adaptive quantization

[The Wanderer]

Guillaume POIRIER wrote:

> Hi,
> 
> On 6/4/05, The Wanderer <inverseparadox at comcast.net> wrote:
> 
>> Guillaume POIRIER wrote:
>> 
>> 
>>> Hi there,
>>> The attached patch adds adaptive quantization to MEncoder for
>>> XviD.
>>> 
>>> Please comment, review (especially the doc part).
>> 
>> Since that's all I'm qualified to review anyway:
> 
> :-)

^_^

>>> +.B (no)adaptive_quant
>>> +Adaptive quantization allows each quant to differ inside each frame.
>> 
>> The phrasing "each quant" seems to imply that there are multiple
>> different quantizers, which if true would be news to me. If it
>> isn't true, then "the quantizer" would be better.
> 
> I'm not 100% sure, but there are 2 types of quants: global picture
> quant and macroblock quant. Here's a better description of this
> options that features your remarks:

That makes sense. The new form, while not necessarily ideal (I'm in an
anal-retentive sort of mood today, such that saying "quant" instead of
"quantizer" annoys me - but I'm sure that mood won't last), is fine as
far as I'm concerned.

(Of course, no sooner did I say that than I saw another thing to pick
at... but I'm not going to keep us at this all week over one short
paragraph!)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.