[MPlayer-dev-eng] Re: Re: Re: fast SPP - working code

[Guillaume POIRIER]

Hi,

On 6/4/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> > > I JUST fixed it, but apperantely I didn't.
> > >
> > > {standard input}:791: Error: Incorrect register `%rdx' used with `l' suffix
> > > {standard input}:800: Error: Incorrect register `%rsi' used with `l' suffix
> > >
> > > Apperantely using commands like 'addl' on those registers is obviously
> > > illegal.. I'm not sure what to do at this point, i've never made 64-bit
> > > code...
> >
> > I think that most of them should be just replaced with the instructions
> > without the suffix (addl->add). But I didn't code any 64bit asm either.
> 
> If that was all... I really though that by now everyone knows that
> casting a pointer to int is not a good idea. Obviously not.
> The attached patch fixes it on AMD64, though it isn't a beauty (esp. the int ->
> long changes).
> I'm also not 100% percent sure the __attribute__((aligned(32))) for that
> on-stack variable will be taken into account by all compilers, but it
> certainly worked for me (and I'm also not sure if 32 isn't overkill)...

Applied by Jindrich Makovicka
-- 
Should I have invented the tape recorder too,
people would have more quotes of me to put
at the bottom of their e-mails
-- Benjamin Franklin