[MPlayer-dev-eng] [PATCH] Adaptive quantization

[The Wanderer]

Guillaume POIRIER wrote:

> Hi there,
> The attached patch adds adaptive quantization to MEncoder for XviD.
> 
> Please comment, review (especially the doc part).

Since that's all I'm qualified to review anyway:

> +.B (no)adaptive_quant
> +Adaptive quantization allows each quant to differ inside each frame.

The phrasing "each quant" seems to imply that there are multiple
different quantizers, which if true would be news to me. If it isn't
true, then "the quantizer" would be better.

Depending on precisely what is meant, and I'll note that I'm not
entirely clear from the description on what exactly happens, you might
want to say "vary" instead of "differ".

> +This is a 'psychosensory'setting that is supposed to make use of the
> +fact that the human eye tends to notice fewer details  in very bright
> +and dark parts of the picture.

Duplicate space after "details". You might also want to repeat "very"
before "dark", but that's optional.

> +It compresses those areas stronger than medium ones, so it will save
> +bits that can be spent again on other frames, raising overall
> +subjective quality, while possibly reducing PSNR.

"stronger" -> "more strongly"

"so it" -> "which"

"quality, while" -> "quality while" or "quality and"

The latter two of these are IMO improvements but aren't necessarily
required; the first, however, is essential.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

A government exists to serve its citizens, not to control them.