[MPlayer-dev-eng] [PATCH] MinGW compile fix, header order policy suggestion

Gianluigi Tiesi mplayer at netfarm.it
Thu Jun 2 06:44:04 CEST 2005


On Wed, Jun 01, 2005 at 11:31:27AM +0200, Reimar D?ffinger wrote:
> Hi,
> On Tue, May 31, 2005 at 08:30:21PM -0400, Rich Felker wrote:
> > Windows is incredibly broken for naming structures so stupid, and
> > polluting the namespace from required headers. I suggest we wrap the
> 
> All you need to do is make sure that the windows headers are included
> _before_ STREAM_SEEK is defined, which is what my patch does.
> Isn't that good enough??
> I just wanted to make a policy out of it to help people avoid making
> mistakes, but that's not essential...
> 
The main problem is mingw headers do not honor -D_LARGEFILE_SOURCE
-D_FILE_OFFSET_BITS=64, simply they have correct struct and functions
but they are not automagically mapped to the right ones when specifing
the above defines.

Bye

-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/




More information about the MPlayer-dev-eng mailing list