[MPlayer-dev-eng] [PATCH] modify X11 lib path search for mixed 32/64 bit case
ikalvachev at gmail.com
Wed Jun 1 13:50:25 CEST 2005
On 6/1/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Wed, Jun 01, 2005 at 01:02:06PM +0300, Ivan Kalvachev wrote:
> > On 6/1/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > Any comments? Because otherwise I will apply real soon.
> > I think I have.
> > 1. I think that program writing `cat > $TMPC ` could be moved out of
> > loop, giving an little performance speedup.
> > 2. By looking at the patch I think that if user sets _x11=no, the lib
> > search will find x11 anyway and set it to yes.
> > So basically both functions should be merged and
> > echocheck "X11"
> > if test "$_x11" != no ; then
> > _x11=no
> > movied on the place of
> > echocheck ""working X11 libs"
> > This way we will not look for X11 libs if x11 is disabled.
> > Probably echocheck text could also be tweaked a little.
> How about the attached patch?
> Reimar Döffinger
1. If user gives x11libdir and the autodetection fails then the we
should keep the given by user dir. (it have the power of force, or it
would have the power of force if x11=yes)
I guess that adding _x11_paths and keeping _ld_x11 would do the trick, but
actually handling _x11=no case could be better:
if test "$_x11" = yes ; then
2. I oppose of removing
- if test -d "$I"
and going with check dirrectly. Invoking build is very slow. I don't
oppose removing the rest of lib test as they doesn't seem too
3.I also wonder if your new version won't break netbsd build
- if netbsd; then
- _ld_x11="-L$I -Wl,-R$I"
Wish You Best
More information about the MPlayer-dev-eng