[MPlayer-dev-eng] [PATCH] modify X11 lib path search for mixed 32/64 bit case

Ivan Kalvachev ikalvachev at gmail.com
Wed Jun 1 12:02:06 CEST 2005


On 6/1/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hi,
> On Sat, May 28, 2005 at 10:22:18PM +0200, Reimar D?ffinger wrote:
> > is the attached patch to fix
> > http://bugzilla.mplayerhq.hu/show_bug.cgi?id=206
> > okay?
> > IMHO it makes sense anyway to check whether the libs can be linked against,
> > and not only if they exist...
> 
> Any comments? Because otherwise I will apply real soon.

I think I have.

1. I think that program writing `cat > $TMPC ` could be moved out of
loop, giving an little performance speedup.

2. By looking at the patch I think that if user sets _x11=no, the lib
search will find x11 anyway and set it to yes.

So basically both functions should be merged and 
    echocheck "X11"
     if test "$_x11" != no ; then
          _x11=no
movied on the place of 
    echocheck ""working X11 libs"

This way we will not look for X11 libs if x11 is disabled.
Probably echocheck text could also be tweaked a little.


Wish You Best
   Ivan Kalvachev
  iive




More information about the MPlayer-dev-eng mailing list