[MPlayer-dev-eng] AMD64 assembler support

[Michael Niedermayer]

Hi

On Sunday 31 July 2005 21:49, Johan Groth wrote:
> Reimar Döffinger wrote:
> >>-static uint64_t attribute_used __attribute__((aligned(8))) magicF2W=
> >> 0x43c0000043c00000LL; -static uint64_t attribute_used
> >> __attribute__((aligned(8))) wm1010= 0xFFFF0000FFFF0000LL; -static
> >> uint64_t attribute_used __attribute__((aligned(8))) wm0101=
> >> 0x0000FFFF0000FFFFLL; -static uint64_t attribute_used
> >> __attribute__((aligned(8))) wm1100= 0xFFFFFFFF00000000LL; +#include
> >> "a52_internal.h"
> >>+
> >>+
> >>+static uint64_t attribute_used __attribute__((aligned(8))) magicF2W=
> >> 0x43c0000043c00000ULL; +static uint64_t attribute_used
> >> __attribute__((aligned(8))) wm1010= 0xFFFF0000FFFF0000ULL; +static
> >> uint64_t attribute_used __attribute__((aligned(8))) wm0101=
> >> 0x0000FFFF0000FFFFULL; +static uint64_t attribute_used
> >> __attribute__((aligned(8))) wm1100= 0xFFFFFFFF00000000ULL;
> >
> > Why this LL -> ULL change?
>
> To quote the GCC info pages:
> "To make an integer constant of type `long
> long int', add the suffix `LL' to the integer.  To make an integer
> constant of type `unsigned long long int', add the suffix `ULL' to the
> integer."
> Hence the change to ULL.

this change is ok, but it should be a seprate patch, not part of the amd64 
stuff

[...]
-- 
Michael