[MPlayer-dev-eng] AMD64 assembler support

[Aurelien Jacobs]

On Sat, 30 Jul 2005 17:52:18 +0100
Johan Groth <johan.groth at cell-telecom.co.uk> wrote:

> Rich Felker wrote:
> 
> > Please use REG_a, REG_b, etc. names like elsewhere in MPlayer, for
> > consistency. Using EAX, EBX, etc. for the macros is confusing
> > because those are the names of the 32bit registers, and on amd64
> > they'll be defined to the 64bit regs..
> 
> Ok, fixed in the attached patch.

I've reworked your patch (cleaned, fixed...).
It seems pretty good now, so I will probably commit.
Also I don't think it's a good idea to merge it with liba52_changes.diff,
so I will probably introduce a new liba52_amd64_changes.diff.

I did some benchmarks on Athlon64.
Here is the command I used :
  mplayer test.vob -vc dummy -ao null -benchmark
I run each test 3 times and only kept the best one.

Results:

pure C
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.319s Sys:  44.836s =   45.155s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  0.7056% Sys: 99.2944% = 100.0000%

3dnow!
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.291s Sys:  44.865s =   45.156s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  0.6449% Sys: 99.3551% = 100.0000%

SSE
BENCHMARKs: VC:   0.000s VO:   0.000s A:   0.273s Sys:  44.881s =   45.154s
BENCHMARK%: VC:  0.0000% VO:  0.0000% A:  0.6046% Sys: 99.3954% = 100.0000%

Current code choose 3dnow! if both 3dnow! and SSE are available. Johan's
patch changed this to prefer SSE if available. This sounds reasonable
giving my benchmark results, but this would also need to be benchmarked
on 32bits Athlon XP. So for now my patch didn't modify this (still prefer
3dnow!).

Can someone please benchmark liba52 with and without liba52_prefer_sse.diff
on SSE enabled Athlon XP ?

Aurel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: liba52_amd64.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050731/bdcf31b7/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: liba52_prefer_sse.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050731/bdcf31b7/attachment.asc>