[MPlayer-dev-eng] [PATCH] Fix return types of libvo API

Ivo ivop at euronet.nl
Fri Jul 29 03:36:48 CEST 2005


Hi,

As stated in an earlier post, the libvo functions that return a value are 
declared wrongly. They return uint32_t, but lots of vo's return -1 in 
certain functions, or  <= VO_ERROR (<= -1). This patch changes all 
declarations and definitions to static int instead of static uint32_t.

Please test on as many machines and configurations you have. About half of 
the vo's are not compiled in on my machine (especially the "obscure" ones 
like dxr* and zr*, etc. and windows and macosx stuff), so they are 
untested. I have proofread the whole patch once for typo's (like init 
instead of int, occured twice) but an error can always have slipped in.

I have not seen any ill effects yet, now that the calling code actually gets 
negative values for VO_ERROR/NOTIMPL/etc., but there might be. Look out for 
them and report back please :)

--Ivo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cvsdiff-u.fix.return.types.libvo
Type: text/x-diff
Size: 68940 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20050729/a206d091/attachment.diff>


More information about the MPlayer-dev-eng mailing list