[MPlayer-dev-eng] libvo return values

Ivo ivop at euronet.nl
Fri Jul 29 02:10:32 CEST 2005


On Thursday 28 July 2005 21:59, Ivo wrote:
> Yes, agreed. But for example config(), which is part of the api, behaves
> wrong IMO. It returns 0 on success and -1 on failure (which doesn't work
> because the return value is unsigned atm, but that will be fixed). In
> fact, the calling code in vf_vo inverts the return value:

In video_out.h the API is actually somewhat documented. Although it's 
incomplete, it does say config returns 0 on success and !0 otherwise. Some 
functions do the same and others are not defined there, but looking at 
actual vo's, they return VO_TRUE/FALSE/etc...

So, OK, it is according to the API, but IMHO that's not a consistent and 
clean API and should be fixed eventually :-)

--Ivo




More information about the MPlayer-dev-eng mailing list