[MPlayer-dev-eng] [PATCH] mp_image flags in filters

[Rich Felker]

On Thu, Jul 28, 2005 at 05:24:08PM +0200, Reimar Döffinger wrote:
> > > harddup: I reuses the same buffers, so shouldn't it set PRESERVE?
> > 
> > Huh? harddup never allocates a buffer, it just exports. There's no way
> > it can tell the previous filter that the image contents must be
> > preserved, BUT the key is that the previous filter will not be called
> > before the duplicate control is called by mencoder.
> 
> Actually I was thinking about the case where somebody would stick a
> filter _after_ it... Sure it doesn't allocate a buffer, but the export
> buffer it passes on could have the preserve flag set...

This is pointless. No filter is ever allowed to modify its input
buffer in-place.

> > > qp: Shouldn't/Couldn't it use EXPORT buffers? After all it doesn't
> > > change the _data_ at all, only the qscale values.
> > 
> > Yes. What does it use now?
> 
> It uses DR with TEMP buffers + memcpy as fallback.

Uhg..

Rich