[MPlayer-dev-eng] [PATCH] mp_image flags in filters

[Reimar Döffinger]

Hi,
On Thu, Jul 28, 2005 at 11:02:29AM -0400, Rich Felker wrote:
> On Thu, Jul 28, 2005 at 01:04:44AM +0300, Ivan Kalvachev wrote:
> > I would preffer this to stay static. Don;t forget that tile is called
> > multiple times over same (result) image
> 
> But it only calls vf_next_put_image once. Thus it does not need static.

Not completely correct I think, it doesn't store the mpi it got but
instead calls vf_get_image every time, assuming it gets the same buffer
as last time :-(

> > boxblur, doesn't seem to support direct rendering. It doesn't
> > implement get_image funtion. So setting readable in the dest image is
> > bad (will actually prevent DR in valid case). I guess that the
> > algorithm requires not to modify the source image.
> 
> ok.

I don't understand that. Neither why it will prevent DR (can you give an
example?), nor why it READABLE isn't necessary, after all that very
filter needs to read from that buffer...

> > denoise3d - same as above
> 
> ok.

It stores the last dmpi on each round and in the next pass reads from it
again. So that dmpi IMHO must be readable (and I check with a hacked
vo_gl.c that performance actually degraded by a factor ten when enabling
DR because it tried to read from video RAM).

> > rectangle - commit. This could really be done better. 

I've been hacking a bit on it, I think it might be possible to use this
one as a sample filter to show how to do a few things right (though I
have to find that out myself first, too *g*).

Greetings,
Reimar Döffinger