[MPlayer-dev-eng] [PATCH] mp_image flags in filters

[Rich Felker]

On Thu, Jul 28, 2005 at 12:40:04PM +0300, Ivan Kalvachev wrote:
> On 7/28/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > Hi,
> > On Thu, Jul 28, 2005 at 01:04:44AM +0300, Ivan Kalvachev wrote:
> > > On 7/27/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > > > For tile I think MP_IMGTYPE_STATIC is not neccessary, as I understand it
> > > > you'd only need that if you call vf_next_put_image more than once with
> > > > the same mp_image, which is not the case here.
> > >
> > > I would preffer this to stay static. Don;t forget that tile is called
> > > multiple times over same (result) image
> > 
> > Well, and when you do memcpy you write into it multiple times as well
> > *g*. No, seriously, what is the criteria for using static? I thought
> > simply that you can use the same mp_image for multiple
> > vf_next_put_image calls (i.e. without having to call get_image again).
> 
> STATIC is used when the buffer should not be moved in the memory. In

False. Static means (and only means) that the recipient of the image
cannot clobber the image _contents_ after vf_next_put_image is called.
The contents must still be there the next time vf_get_image is called.

As for the pointer, naturally it cannot change until vf_next_put_image
is called. After that, all bets are off, regardless of the static
flag.

Rich