[MPlayer-dev-eng] [PATCH] mp_image flags in filters

[Rich Felker]

On Thu, Jul 28, 2005 at 01:08:19PM +0300, Ivan Kalvachev wrote:
> On 7/28/05, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> > Hi,
> > > I think a lot of filters use the wrong flags in their vf_get_image
> > 
> > I forgot a few other things I saw that I think are wrong.
> > E.g.
> > vf_eq, vf_eq2 and vf_hue modify the original image and export them.
> > But in case PRESERVE is set on the original this is incorrect i think?
> > Could this be the reason for some people seeing a "pumping" effect when
> > decoding e.g. MPEG4 files?
> 
> Sure.

Don't think so.

> > harddup: I reuses the same buffers, so shouldn't it set PRESERVE?
> 
> Yes.

No. There's no way it can.

> > qp: Shouldn't/Couldn't it use EXPORT buffers? After all it doesn't
> > change the _data_ at all, only the qscale values.
> 
> It implements own get_image() so it get next buffer, returns it as him own,
> and then this buffer comes back in put_image()  as DIRECT.
> Buffer that are not DR-ed are these with PRESERVE.
> 
> I don't see much sense in change TEMP to EXPORT.

Oh, it's doing DR? That's better, but if DR is not available it should
fallback to exporting forward rather than copying. Maybe it already
does..?

Rich