[MPlayer-dev-eng] [PATCH] mp_image flags in filters

[Rich Felker]

On Thu, Jul 28, 2005 at 01:56:30AM +0200, Reimar Döffinger wrote:
> Hi,
> > I think a lot of filters use the wrong flags in their vf_get_image
> 
> I forgot a few other things I saw that I think are wrong.
> E.g.
> vf_eq, vf_eq2 and vf_hue modify the original image and export them.

They do not modify the original last I checked. The export the
original plane for unmodified planes, and an internal buffer for
planes they modify. If they're modifying the original image, it's
blatently wrong, and someone else must have introduced that
brokenness..

> But in case PRESERVE is set on the original this is incorrect i think?

Definitely.

> Could this be the reason for some people seeing a "pumping" effect when
> decoding e.g. MPEG4 files?

IMO no.

> harddup: I reuses the same buffers, so shouldn't it set PRESERVE?

Huh? harddup never allocates a buffer, it just exports. There's no way
it can tell the previous filter that the image contents must be
preserved, BUT the key is that the previous filter will not be called
before the duplicate control is called by mencoder.

> kerndeint: It requests two buffers. is this allowed? Why is it
> neccessary? I had the impression that one of these is really only used
> for temporary storage (filter internal), I think that's not what
> MP_IMGTYPE_TEMP is thought for?

I agree. This could seriously break DR setups with a low number of
buffers.

> qp: Shouldn't/Couldn't it use EXPORT buffers? After all it doesn't
> change the _data_ at all, only the qscale values.

Yes. What does it use now?

Rich