[MPlayer-dev-eng] libvo return values

Rich Felker dalias at aerifal.cx
Thu Jul 28 16:47:15 CEST 2005


On Thu, Jul 28, 2005 at 12:55:24AM +0200, Ivo wrote:
> Hi,
> 
> Here's the problem. All non-void functions of libvo drivers are defined 
> static uint32_t. That seems weird to me, because the return values can be 
> negative (like VO_ERROR, VO_NOTIMPL, etc) and are used all over the place, 
> but without any effect I suppose.
> 
> What do you think? Should they all be changed to static int32_t?

They should be changed to int. Types of specific size should never be
used except for addressing sample buffers and the like.

Rich




More information about the MPlayer-dev-eng mailing list