[MPlayer-dev-eng] [PATCH] mp_image flags in filters

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Jul 28 01:56:30 CEST 2005


Hi,
> I think a lot of filters use the wrong flags in their vf_get_image

I forgot a few other things I saw that I think are wrong.
E.g.
vf_eq, vf_eq2 and vf_hue modify the original image and export them.
But in case PRESERVE is set on the original this is incorrect i think?
Could this be the reason for some people seeing a "pumping" effect when
decoding e.g. MPEG4 files?
harddup: I reuses the same buffers, so shouldn't it set PRESERVE?
kerndeint: It requests two buffers. is this allowed? Why is it
neccessary? I had the impression that one of these is really only used
for temporary storage (filter internal), I think that's not what
MP_IMGTYPE_TEMP is thought for?
qp: Shouldn't/Couldn't it use EXPORT buffers? After all it doesn't
change the _data_ at all, only the qscale values.

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list