[MPlayer-dev-eng] [PATCH] CQMs in x264

[Robert Swain]

On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Jul 26, 2005 at 12:20:56PM +0100, Robert Swain wrote:
> > On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > > something along the lines of
> > >
> > > cqm[=<flat | jvt | <filename> >]
> > >
> > > Look around the man page for examples.
> >
> > I've used the xvid quant_type style and gone for cqm=<jvt|flat|<filename>>.
> 
> The [] are there for a reason most of the time, btw.  Does specifying
> just cqm without parameters work?  Then add [].

Were you expecting me to answer 'No'? I assume you were. So [] means
that the parameter is mandatory?

> > Apologies, I thought I'd sent the patch to the ML, it turns out I'd
> > only sent it to someone privately. :) Please find revision 11
> > attached.
> >
> > I'd like to have a line space after "The provided JM format matrix
> > file is used." but everything I try breaks it.
> 
> .sp 1
> 
> But the rest of the man page does not use empty lines in these cases, so
> better avoid it.

But this is a different case. See my comments about the paragraph below.

> > Otherwise it really does look fine to me.
> 
> Better, but not fine.  Add a "\ " after jvt: to force a linebreak.  Then
> look at the subq option to see how to keep the correct paragraph
> indentation.

OK.

> Are the : after the option names necessary?  Your description does not
> make that clear, you're showing both variants.

No. I was following an example from elsewhere in the documentation.
 
> What is the whole paragraph after the option descriptions about?  I
> cannot figure out the connection to the cqm option.  You start talking
> about lists, what lists?

I added another method of input on request. In the x264 CLI interface
you can specify comma separated lists of values for the matrices. The
paragraph just explains that the following cqm* x264 options are for
the corresponding comma separated lists. The reason it isn't related
to the cqm option is because this was the neatest and most
comprehensible way to implement it in my opinion. Should I remove the
paragraph or move it to be below the cqm list options?

> > Is it worth adding a note for windows users that
> > they won't be able to use full lists with cmd.exe because the
> > commandline length is too great? And also that there is no way to pass
> > absolute paths using cmd.exe because of ':'?
> 
> Sure, they will most likely appreciate it.

...or at least they will appreciate that cmd.exe isn't very good.

Regards,
Robert Swain (superdump)