[MPlayer-dev-eng] [PATCH] CQMs in x264

[Robert Swain]

On 7/25/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> On 7/25/05, Robert Swain <robert.swain at gmail.com> wrote:
> > Diego: There's one long line I've left in the man page because the
> > formatting breaks if I put it onto a new line. Feel free to play with
> > the wording and formatting as you wish. :)
> 
> That'd have to be fixed. I'll have a look at it tonight.

OK. I didn't know how.

> > Does that all look OK now?
> 
> +.br
> +.B cqm4iy=<list>
> +.br
> +.B cqm4ic=<list>
> +.br
> +.B cqm4py=<list>
> +.br
> +.B cqm4pc=<list>
> +.br
> +.B cqm8i=<list>
> +.br
> +.B cqm8p=<list>
> +.br
> 
> What do each of those list correspond to ? Also, you need to add ".TP"
> before each new option name.
> 
> I guess you should write smth like:
> .TP
> +.B cqm4iy=<list>
> +custom intra 4x4 luma matrix
> +.
> +.TP
> +.B cqm4ic=<list>
> +custom....
> +.
> +.TP
> +.B cqm4py=<list>
> +custom....
> +.
> +.TP
> +.B cqm4pc=<list>
> +custom....
> +.
> +.TP
> +.B cqm8i=<list>
> +custom....
> +.
> +.TP
> +.B cqm8p=<list>
> 
> See what I mean?

Yes. That would be better. They are, respectively, the 4x4 intra luma,
4x4 intra chroma, 4x4 inter luma, 4x4 inter chroma, 8x8 intra and 8x8
inter matrices. I was going to do the .TP thing for each but it looked
a bit too spaced out. Do with it as you will though. :) I don't really
want to go through another 5 revisions altering documentation until
it's acceptible. ;) Note that in the CQM files I sent you there are
separate chroma matrices defined for each of the U and V channels and
note that there is only one chroma matrix used in x264. I'm not sure
why that is but that's how it is in the core, so that's how it is. :)

> +.I NOTE:
> +These lists will override the cqm option.
> 
> How about smth like "Each of these lists will override the
> corresponding custom quantization matrix" ?

That might be better than having two notes, yes.

> Looking forward for the 10th revision of your patch ;-)

Nooooooooo! :D Unless there's something wrong with the implementation,
I'll try to leave the docs to you guys apart from suggesting the
content.

Regards,
Robert Swain (superdump)