[MPlayer-dev-eng] [PATCH] CQMs in x264

[Alexander Strasser]

Robert Swain wrote:
> You are indeed correct and this had already come to mind. Would it be
> OK to do something like this?:
> 
> +            FILE *cqm_test;
> +            cqm_test = fopen( cqm + 5, "rb" );
> +            if( cqm_test )
> +            {
> +                mod->param.i_cqm_preset = X264_CQM_CUSTOM;
> +                mod->param.psz_cqm_file = cqm + 5;
> +                mp_msg( MSGT_MENCODER, MSGL_V, "x264: CQM file
> correctly loaded.\n" );
> +            }
> +            else
> +            {
> +                mp_msg( MSGT_MENCODER, MSGL_ERR, "x264: CQM file
> failed to open.\n" );
> +                return 0;
> +            }
> 
> I know it doesn't check whether the file was parsed correctly but is
> that possible before encoding begins?

  Not really. IMHO just say
mp_msg( MSGT_MENCODER, MSGL_V, "x264: CQM file: %s.\n", cqm + 5 );

  Alex (beastd)